Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutable dataclass defaults #1082

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

yasyf
Copy link
Contributor

@yasyf yasyf commented Jul 10, 2024

Prevents a ValueError on py3.12

Prevents a ValueError on py3.12
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 10, 2024
@yasyf
Copy link
Contributor Author

yasyf commented Jul 10, 2024

@shahules786 @jjmachan

@jjmachan
Copy link
Member

thanks a lot @yasyf ❤️

@jjmachan jjmachan merged commit 0172bda into explodinggradients:main Jul 10, 2024
5 checks passed
@yasyf yasyf deleted the patch-1 branch July 10, 2024 22:21
@shahules786
Copy link
Member

Hey @yasyf Very interesting & curious at the same time to see you were quick to try out experimental test generation ( we haven't made announcement yet) . Would love to chat and learn more about your interest in it https://cal.com/shahul-ragas/30min

@yasyf
Copy link
Contributor Author

yasyf commented Jul 12, 2024

@shahules786 still havent got it working actually, hit a few more bugs that I didn't have time to dive into. ya happy to chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants