-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate add_guard #195
Deprecate add_guard #195
Conversation
@gilbo Can you take a brief look at the changes, before I change all the use cite of |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 83.81% 84.85% +1.03%
==========================================
Files 67 66 -1
Lines 14461 14629 +168
==========================================
+ Hits 12121 12413 +292
+ Misses 2340 2216 -124
Continue to review full report at Codecov.
|
Looks great! |
@alexreinking Thanks, I still need to remove more use cite of |
I think it's fine to merge this first, but if you want to wait, that's fine, too. |
@gilbo @alexreinking I'll merge this PR if it looks alright~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a little clean-up and I'll approve.
Co-authored-by: Alex Reinking <alex.reinking@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just did the merge with master
myself, so we'll just wait for green. Go ahead and enable auto-merge.
No description provided.