Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate add_guard #195

Merged
merged 14 commits into from
May 23, 2022
Merged

Deprecate add_guard #195

merged 14 commits into from
May 23, 2022

Conversation

yamaguchi1024
Copy link
Member

No description provided.

@yamaguchi1024 yamaguchi1024 requested a review from gilbo May 19, 2022 18:58
@yamaguchi1024
Copy link
Member Author

@gilbo Can you take a brief look at the changes, before I change all the use cite of add_guard ?

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #195 (7419efa) into master (e058969) will increase coverage by 1.03%.
The diff coverage is 100.00%.

❗ Current head 7419efa differs from pull request most recent head e91cf62. Consider uploading reports for the commit e91cf62 to get more accurate results

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   83.81%   84.85%   +1.03%     
==========================================
  Files          67       66       -1     
  Lines       14461    14629     +168     
==========================================
+ Hits        12121    12413     +292     
+ Misses       2340     2216     -124     
Impacted Files Coverage Δ
src/exo/API.py 72.50% <100.00%> (+0.93%) ⬆️
src/exo/LoopIR_scheduling.py 84.07% <100.00%> (-0.45%) ⬇️
tests/gemmini/conv/test_gemmini_conv_ae.py 100.00% <100.00%> (ø)
tests/gemmini/conv/test_gemmini_conv_no_pad.py 100.00% <100.00%> (ø)
tests/gemmini/conv/test_gemmini_conv_stride1.py 51.23% <100.00%> (+4.20%) ⬆️
tests/gemmini/matmul/test_gemmini_matmul_ae.py 100.00% <100.00%> (ø)
tests/gemmini/matmul/test_gemmini_resnet_matmul.py 100.00% <100.00%> (ø)
tests/test_schedules.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ecc64...e91cf62. Read the comment docs.

@alexreinking alexreinking self-requested a review May 20, 2022 16:13
alexreinking
alexreinking previously approved these changes May 20, 2022
@alexreinking alexreinking marked this pull request as ready for review May 20, 2022 16:15
@alexreinking
Copy link
Contributor

Looks great!

@yamaguchi1024
Copy link
Member Author

@alexreinking Thanks, I still need to remove more use cite of add_guard for this PR

@alexreinking
Copy link
Contributor

I think it's fine to merge this first, but if you want to wait, that's fine, too.

@yamaguchi1024 yamaguchi1024 changed the title Remove the use of add_guard Deprecate add_guard May 20, 2022
@yamaguchi1024
Copy link
Member Author

@gilbo @alexreinking I'll merge this PR if it looks alright~

@alexreinking alexreinking self-requested a review May 23, 2022 00:29
@alexreinking alexreinking dismissed their stale review May 23, 2022 00:29

PR changed a lot

Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a little clean-up and I'll approve.

tests/gemmini/conv/test_gemmini_conv.py Show resolved Hide resolved
tests/gemmini/conv/test_gemmini_conv_stride1.py Outdated Show resolved Hide resolved
src/exo/API.py Outdated Show resolved Hide resolved
yamaguchi1024 and others added 2 commits May 24, 2022 07:32
Co-authored-by: Alex Reinking <alex.reinking@gmail.com>
@yamaguchi1024 yamaguchi1024 enabled auto-merge (squash) May 23, 2022 22:33
Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just did the merge with master myself, so we'll just wait for green. Go ahead and enable auto-merge.

@yamaguchi1024 yamaguchi1024 merged commit 6315f1c into master May 23, 2022
@yamaguchi1024 yamaguchi1024 deleted the add_guard branch May 23, 2022 23:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants