Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated added prerequisites to the practice and concepts V3 #421 #509

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

updated added prerequisites to the practice and concepts V3 #421 #509

wants to merge 2 commits into from

Conversation

rakshitdabral
Copy link

gave prerequisites to practice while removing all the topics also added slag to concepts

@rakshitdabral rakshitdabral changed the title updated V3 #421 updated added prerequisites to the practice and concepts V3 #421 Feb 15, 2022
KevDi
KevDi reviewed Feb 25, 2022
View reviewed changes
config.json Outdated
"strings"
]
"practices": ["string","input and output"],
"prerequisites": ["baics"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo here i think you mean basic or?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep thanks..will update it by tomorrow

KevDi
KevDi reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@KevDi KevDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found just one typo in the beginning .
Rest looks from my point of view good to go.

@kytrinyx
Copy link
Member

Thank you so much for taking the time to do this work.

From the documentation (https://exercism.org/docs/building/tracks/practice-exercises)

The practices key should list the slugs of Concepts that this Practice Exercise actively allows a student to practice.

The prerequisites key lists the Concepts that a student must have completed in order to access this Practice Exercise.

Since this track only has one wip concept, we can't merge this yet. I'm going to put it on hold so that we can bring in these values if and when concepts do get implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevDi KevDi KevDi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
on-hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakshitdabral @kytrinyx @KevDi