-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 IMPROVE: Styling for tabs #21
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 10 10
Lines 859 859
=======================================
Hits 763 763
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
To compare: Current (alabaster theme): (on hover) PR (alabaster theme): (on hover) https://squidfunk.github.io/mkdocs-material/reference/content-tabs (the original inspiration) (on hover) another point of reference is https://material-ui.com/components/tabs/#customized-tabs: |
Thanks for the RP, given the above,
yep fair
This is fine, but currently the change on hover is not really noticeable any more. I would still use (almost) the same active label color for hovering.
I disagree with this one; the selected tab underline is intended to be thicker than the rest of the line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Hey @pradyunsg just giving a gentle nudge, to get your thoughts on my feedback 😬 |
- Introduce "hover" state styling for tabs. The lifecycle of a tab is now "inactive -> hover -> active". - Completely unmix styling for different states of a tab. - Use a higher contrast color for inactive tabs.
A more neutral colour to fit in better with the rest of the content.
As part of addressing review feedback.
Looks great cheers! |
now "inactive -> hover -> active".