Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Make default blue color a11y friendly. #124

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

feanil
Copy link

@feanil feanil commented Mar 1, 2023

The default blue of #007bff is often on white backgrounds. In this case the contrast ration is about 3.97. This means that it is considered inaccessible based on the W3C WCAG standard. Update to be a slightly darker blue by default, thus making the design more accessible without further customizing.

See https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Perceivable/Color_contrast for more context.

The default blue of #007bff is often on white backgrounds.  In this case the contrast
ration is about 3.97.  This means that it is considered inaccessible based on the W3C
WCAG standard. Update to be a slightly darker blue by default, thus making the design
more accessible without further customizing.

See https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Perceivable/Color_contrast for more context.
@welcome
Copy link

welcome bot commented Mar 1, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@feanil feanil changed the title Update the default blue to make it more accessible. [ENH] Update the default blue to make it more accessible. Mar 1, 2023
@feanil feanil changed the title [ENH] Update the default blue to make it more accessible. [ENH, STY] Update the default blue to make it more accessible. Mar 1, 2023
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - I think we want to keep the defaults a11y-friendly so I'll merge this one

@choldgraf choldgraf changed the title [ENH, STY] Update the default blue to make it more accessible. ENH: Make default blue color a11y friendly. Apr 6, 2023
@choldgraf choldgraf merged commit e8fb510 into executablebooks:main Apr 6, 2023
@welcome
Copy link

welcome bot commented Apr 6, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@feanil feanil deleted the patch-1 branch April 10, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants