-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 Expand support for Python-Markdown in the admon plugin #94
👌 Expand support for Python-Markdown in the admon plugin #94
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 91.25% 92.68% +1.42%
==========================================
Files 31 31
Lines 1841 1817 -24
==========================================
+ Hits 1680 1684 +4
+ Misses 161 133 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 5549321.
This reverts commit b742c15.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged changes from #95
Looks good to me. 👍 |
@chrisjsewell, this is a backward compatible change to resolve #93 that is ready for review when you have a chance |
Just bumping this PR! It is still ready for review/merge if there are no concerns |
A friendly bump! This PR is ready for review and merge. @chrisjsewell, I would like to merge this PR when possible Edit: the changes to support content tabs does not require changes to This PR should still be merged because it makes a minor fix to the behavior of the admonitions plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good cheers!
Fixes #93
Added missing HTML roles as identified by #93(removed after clarification in a comment below)