Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture response #41

Merged
merged 14 commits into from
Oct 26, 2022
Merged

Capture response #41

merged 14 commits into from
Oct 26, 2022

Conversation

clementh59
Copy link
Member

@clementh59 clementh59 commented Sep 9, 2022

Features

  • Create a new class: CaptureResponse. This class has some helpers that let developers know what happened with the EPCISDocument they captured.

larizgoitia and others added 6 commits October 5, 2022 12:00
- Added check for null headers and null location in captureResponse constructor
- Simplified location set in constructor
captureResponse.spec.js
- Added tests for constructor's conditions
- Moved hardcoded values to variables (local and from responses.js)
- Updated documentation
- The capture job information are now fetched by appending the capture job ID to 'API_URL/capture/'
- Added more tests for the capture job polling
- renamed the capture job polling function
- Applied linter
larizgoitia
larizgoitia previously approved these changes Oct 26, 2022
test/helper/responses.js Outdated Show resolved Hide resolved
Co-authored-by: larizgoitia <iker@evrythng.com>
@clementh59 clementh59 merged commit f528631 into master Oct 26, 2022
@clementh59 clementh59 deleted the capture-response branch October 26, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants