Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cors by default #794

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Disable cors by default #794

merged 2 commits into from
Jun 29, 2024

Conversation

evroon
Copy link
Owner

@evroon evroon commented Jun 29, 2024

It's too confusing for new users and we have a warning if you disable it on production anyway.

@evroon evroon self-assigned this Jun 29, 2024
Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bracket ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 11:22am

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (5980366) to head (e18b94c).

Files Patch % Lines
backend/bracket/app.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   92.72%   92.70%   -0.03%     
==========================================
  Files         108      108              
  Lines        3727     3730       +3     
==========================================
+ Hits         3456     3458       +2     
- Misses        271      272       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evroon evroon merged commit 19bb866 into master Jun 29, 2024
9 checks passed
@evroon evroon deleted the disable-cors-by-default branch June 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant