Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose port 8400 in backend Dockerfile #671

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

djpiper28
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 29, 2024

@djpiper28 is attempting to deploy a commit to the evroon's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bracket ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 9:36pm

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (f2f35cb) to head (23cd015).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         123      123           
  Lines        3938     3938           
=======================================
  Hits         3560     3560           
  Misses        378      378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evroon evroon changed the title fix: expose port 8400 Expose port 8400 in backend Dockerfile May 3, 2024
@evroon
Copy link
Owner

evroon commented May 3, 2024

I didn't add it at first because I think it is a confusing option (it doesn't actually expose anything, it's more of a documentation thing.

See https://docs.docker.com/reference/dockerfile/#expose:

The EXPOSE instruction doesn't actually publish the port.

But it might help to understand which port needs to be published by just reading the Dockerfile, so why not

@evroon evroon merged commit 0589169 into evroon:master May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants