Add user registration to cli #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel. @evroon first needs to authorize it. |
evroon
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Thanks, this is useful!
A few suggestions.
Could you also make sure the CI succeeds? https://github.com/robigan/bracket/actions/runs/7989651896/job/21816653345
Co-authored-by: Erik Vroon <erik.vroon22@gmail.com>
Co-authored-by: Erik Vroon <erik.vroon22@gmail.com>
Co-authored-by: Erik Vroon <erik.vroon22@gmail.com>
robigan
force-pushed
the
user-reg-from-cli
branch
from
f610fbe
to
30faa67
Compare
I just actually made the modifications based on pre-existing code, applied the changes to a production machine (as I needed a separate account) and they had seemed to have worked. I'll install the dev tool chain and I'll run the checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom function to be able to add users from the CLI. This is a bare-bones modification to cli.py that works, and I've semi tested (against a production environment lol). I am opening this PR as an RFC.