-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved frontend dockerfile #498
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel. @evroon first needs to authorize it. |
Currently in the process of testing the Dockerfile |
8043bc3
to
ebd8294
Compare
Ok, here are my final changes. Please see https://github.com/vercel/next.js/blob/canary/examples/with-docker/Dockerfile for a more up to date version of a modern Dockerfile that builds Next.js applications |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this! I see the size decreased from 3GB to 1.3GB, nice
I have some questions/suggestions
ebd8294
to
9f8f26c
Compare
Gonna upload the proposed bash changes in a moment |
Ok done, @evroon that is the proposed changes implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Closes #495