Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved frontend dockerfile #498

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

robigan
Copy link
Contributor

@robigan robigan commented Feb 20, 2024

Closes #495

Copy link

vercel bot commented Feb 20, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel.

@evroon first needs to authorize it.

@robigan
Copy link
Contributor Author

robigan commented Feb 20, 2024

Currently in the process of testing the Dockerfile

@robigan
Copy link
Contributor Author

robigan commented Feb 20, 2024

Ok, here are my final changes. Please see https://github.com/vercel/next.js/blob/canary/examples/with-docker/Dockerfile for a more up to date version of a modern Dockerfile that builds Next.js applications

@robigan robigan marked this pull request as ready for review February 20, 2024 17:33
Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
bracket ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:59pm

Copy link
Owner

@evroon evroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! I see the size decreased from 3GB to 1.3GB, nice
I have some questions/suggestions

frontend/docker-entrypoint.sh Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
frontend/docker-entrypoint.sh Outdated Show resolved Hide resolved
frontend/Dockerfile Outdated Show resolved Hide resolved
@robigan
Copy link
Contributor Author

robigan commented Feb 21, 2024

Gonna upload the proposed bash changes in a moment

@robigan
Copy link
Contributor Author

robigan commented Feb 21, 2024

Ok done, @evroon that is the proposed changes implemented

@robigan robigan requested a review from evroon February 21, 2024 17:08
Copy link
Owner

@evroon evroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@evroon evroon merged commit 34cf05b into evroon:master Feb 21, 2024
1 check failed
@robigan robigan deleted the improved-frontend-dockerfile branch February 21, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variables not available at build time during Dockerfile build
2 participants