Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using fixed db ids in tests #203

Merged
merged 1 commit into from
May 2, 2023
Merged

Stop using fixed db ids in tests #203

merged 1 commit into from
May 2, 2023

Conversation

evroon
Copy link
Owner

@evroon evroon commented May 2, 2023

fixes #202

@evroon evroon self-assigned this May 2, 2023
@vercel
Copy link

vercel bot commented May 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bracket ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 7:22pm

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #203 (43b8a58) into master (352f461) will decrease coverage by 0.82%.
The diff coverage is 80.30%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   95.26%   94.45%   -0.82%     
==========================================
  Files          57       58       +1     
  Lines        1691     1730      +39     
==========================================
+ Hits         1611     1634      +23     
- Misses         80       96      +16     
Impacted Files Coverage Δ
backend/tests/integration_tests/sql.py 96.34% <ø> (-0.05%) ⬇️
backend/tests/integration_tests/api/conftest.py 73.68% <47.82%> (-26.32%) ⬇️
backend/bracket/sql/matches.py 91.66% <91.66%> (ø)
backend/bracket/routes/matches.py 100.00% <100.00%> (ø)
backend/bracket/routes/models.py 100.00% <100.00%> (ø)
backend/bracket/utils/dummy_records.py 100.00% <100.00%> (ø)
backend/tests/integration_tests/api/auth_test.py 100.00% <100.00%> (ø)
...ackend/tests/integration_tests/api/matches_test.py 100.00% <100.00%> (ø)
...ackend/tests/integration_tests/api/players_test.py 100.00% <100.00%> (ø)
backend/tests/integration_tests/api/rounds_test.py 100.00% <100.00%> (ø)
... and 5 more

@evroon evroon changed the title Implement parallel tests Stop using fixed db ids in tests May 2, 2023
@evroon evroon marked this pull request as ready for review May 2, 2023 19:21
@evroon evroon merged commit 731488e into master May 2, 2023
@evroon evroon deleted the parallel-tests branch May 2, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel tests
1 participant