Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #547: Category scrolling in mobile view #578

Merged

Conversation

adexh
Copy link
Contributor

@adexh adexh commented Jul 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

In the mobile view, when the categories are going out of screen in the filter view. It is not scrollable and categories out of screen are hidden.

Issue Number: #547

What is the new behavior?

The filter view in mobile screen is now scrollable. If the categories go out of screen, it becomes scrollable and none of the categories will be hidden.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Added padding in the category filter for mobile view, so that the filter button does not overlap the checkbox of the last category.

@treoden treoden merged commit c4d175d into evershopcommerce:main Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants