Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/met 5490 angular 16 update #157

Merged
merged 9 commits into from
Sep 28, 2023

Conversation

andyjmaclean
Copy link
Contributor

No description provided.

Copy link

@jeortizquan jeortizquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran test and e2e tests.

src/app/app.module.ts Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in person, the use inject method will become gradually the standard in all metis projects. Personally now looking at this code I am not a fan of having the two types of injection in the code. Eventually one style needs to be used as a standard in code. In this example we see inject and Inject meaning different things in a sense.

@andyjmaclean andyjmaclean removed the request for review from JoanaCMS September 28, 2023 15:35
@andyjmaclean andyjmaclean merged commit e599184 into develop Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants