-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/met 4756 angular 14 #141
Conversation
@@ -820,9 +821,11 @@ describe('OverviewComponent', () => { | |||
).toBeTruthy(); | |||
}); | |||
|
|||
it('should get the total figure', () => { | |||
it('should get the total figure', fakeAsync(() => { | |||
tick(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, just asking ?... but this tick(1)
for fakeAsync
it seems unnecessary.
The overview tests run fine without it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adolfopeixinho Removed!
@@ -36,6 +36,8 @@ | |||
"polyfills": "src/polyfills.ts", | |||
"tsConfig": "tsconfig.app.json", | |||
"allowedCommonJsDependencies": [ | |||
"html2canvas", | |||
"rgbcolor", | |||
"core-js", | |||
"polylabel", | |||
"raf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps add, to the end of the angular configuration, a no-tracking analytics by default?
"cli": { "analytics": false }
No description provided.