Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: identify side effect free workspace modules #2363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/i18n/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "Europeana i18n",
"license": "EUPL-1.2",
"type": "module",
"sideEffects": false,
"main": "./src/index.js",
"exports": {
".": "./src/index.js"
Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/src/codes.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import locales from './locales.js';

export default locales.map(locale => locale.code);
export default locales.map((locale) => locale.code);
1 change: 1 addition & 0 deletions packages/oembed/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import axios from 'axios';
import escapeRegExp from 'lodash/escapeRegExp.js';
import providers from './providers.js';

// TODO: why is this side effect in here, and not done in provider.js?
for (const provider of providers) {
provider.schemeRegExps = provider.schemes.map((scheme) => {
const escaped = escapeRegExp(scheme).replace(/\\\*/g, '.+');
Expand Down
1 change: 1 addition & 0 deletions packages/vue-router-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "Vue Router query",
"license": "EUPL-1.2",
"type": "module",
"sideEffects": false,
"exports": {
".": "./src/index.js"
},
Expand Down
1 change: 1 addition & 0 deletions packages/vue-session/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "Vue session",
"license": "EUPL-1.2",
"type": "module",
"sideEffects": false,
"exports": {
".": "./src/index.js"
},
Expand Down
1 change: 1 addition & 0 deletions packages/vue-visible-on-scroll/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "Vue visible-on-scroll directive",
"license": "EUPL-1.2",
"type": "module",
"sideEffects": false,
"exports": {
".": "./src/index.js"
},
Expand Down
Loading