bug/MET-5119 intermittent enrichment error #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ull instead of 500 internal server error
jeortizquan
changed the title
…ttent_enrichment_error
…ng stacktrace when an error occured
JoanaCMS
reviewed
Apr 5, 2023
...chment-client/src/main/java/eu/europeana/enrichment/rest/client/enrichment/EnricherImpl.java
Outdated
Show resolved
Hide resolved
...chment-client/src/main/java/eu/europeana/enrichment/rest/client/enrichment/EnricherImpl.java
Outdated
Show resolved
Hide resolved
...chment-client/src/main/java/eu/europeana/enrichment/rest/client/enrichment/EnricherImpl.java
Show resolved
Hide resolved
...chment-client/src/main/java/eu/europeana/enrichment/rest/client/enrichment/EnricherImpl.java
Outdated
Show resolved
Hide resolved
...metis-enrichment-client/src/main/java/eu/europeana/enrichment/rest/client/report/Report.java
Outdated
Show resolved
Hide resolved
JoanaCMS
reviewed
Apr 7, 2023
| warningStatus = containsWarningStatus(exception.getMessage()); | ||
| } else { | ||
| warningStatus = containsWarningStatus(rootCause.getMessage()); | ||
| if (warningStatus != null) { |
There was a problem hiding this comment.
Shouldn't this if be outside of the if...else?
There was a problem hiding this comment.
No. This inner if applies only when the rootCause exists otherwise the exception field can be null if a take it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.