Improve the widget for the sector logo #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
approved these changes
May 27, 2024
|
|
||
|
|
||
| class LogoWidget(NamedImageWidget): | ||
| pass |
There was a problem hiding this comment.
You could limit the accepted types via the accept attribute, if you want.
e.g.:
class LogoWidget(NamedImageWidget):
accept = ("*.png", "*.jpg", "*.gif", "*.webp")
... or maybe add the accept parameter in the directives statement above.
Note: out of my head, untested....
| title="Information" | ||
| i18n:attributes="title" | ||
| i18n:translate="help_sector_logo" | ||
| >The logo will appear on the client side app that your user group will see. Make sure your image is of format png, jpg or gif and does not contain any special characters. The new logo will only become visible after you've saved your changes and published the OiRA tool.</dfn> |
There was a problem hiding this comment.
I'd also recommend to use webp as it produces very good results with a lower filesize and also offers lossless compression.
|
What you propose are different tasks that should be done in other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to remove a customized template that rewrites the whole form in other packages, see for example:
But we have something similar for other projects.