Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrum 2193 notifications allow user settings #726

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

thet
Copy link
Member

@thet thet commented Apr 26, 2024

Ref: scrum-2193

Define a registry record to dissallow users to set their notification settings in the user profile, while still showing what is configured. Also show a info explaining why this cannot be changed.

image

For the speficic site, this setting can simple be set via the registry.

Add registry setting `euphorie.notifications__allow_user_settings` to allow users to change their notification settings.
The default is set to `True` to allow users to do changes on their own.
This can be prevented if internal policies require so by changing this setting to `False`.

Ref: scrum-2193
Ref: scrum-2193
@thet thet requested a review from reinhardt April 26, 2024 21:49
Copy link
Contributor

@reinhardt reinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in the ticket I disagree with the premise, but in terms of code quality it's just fine.

@thet thet merged commit e4cd847 into main Apr 30, 2024
2 checks passed
@thet thet deleted the scrum-2193--notifications-allow-user-settings branch April 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants