Skip to content

Commit

Permalink
Move express and node types to prod deps (#290)
Browse files Browse the repository at this point in the history 
* move express and node types to prod deps

* fix url typo
  • Loading branch information
@eugef
eugef committed Jan 3, 2024
1 parent 236d902 commit 153308f
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 40 deletions.
74 changes: 36 additions & 38 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
"node": ">=14"
},
"dependencies": {
"@types/express": "^4.17.21",
"@types/node": "^20.10.6",
"accepts": "^1.3.7",
"content-disposition": "^0.5.3",
"depd": "^1.1.0",
Expand All @@ -59,9 +61,7 @@
},
"devDependencies": {
"@types/chai": "^4.3.11",
"@types/express": "^4.17.17",
"@types/mocha": "^10.0.6",
"@types/node": "^14",
"chai": "^4.2.0",
"eslint": "^7.7.0",
"gulp": "^4.0.2",
Expand Down

2 comments on commit 153308f

@mhaligowski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we run into some issues with this? I'm curious how did you realize that this needs to be changed.

@eugef
Copy link
Owner Author

@eugef eugef commented on 153308f Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was reported in this issue #289

I've also checked a bunch of other libs that depend on @types/express and @types/node and they have them in prod dependencies

Please sign in to comment.