Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add XYZ axis labels + camera names to 3D plot #653

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

mandulaj
Copy link
Contributor

The Axis in the plot are confusing. Adding labels also to differentiate the cameras makes it much easier to orient.

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@goldbattle
Copy link
Collaborator

Could you add a screen shot of what it looks like now? Thanks!

@mandulaj
Copy link
Contributor Author

Of course, here is the plot with XYZ axis labeled and a accompanying camera label for each of the poses:

image

@mandulaj
Copy link
Contributor Author

BTW: It seems the Build errors in Ubuntu 16 and 18 are related to some unauthenticated packages:

E: There were unauthenticated packages and -y was used without --allow-unauthenticated

@goldbattle
Copy link
Collaborator

These look nice. Could you push a fix for the two dockers too? Many thanks!

@mandulaj
Copy link
Contributor Author

mandulaj commented Dec 4, 2023

@goldbattle I made a pull request with the Docker packages fix in #655. It built on my system so lets see if it passes the build test on Github.

I would consider pushing the images to a registry (either Dockerhub or Github) so that they don't have to be rebuild every time. Let me know if you would like some help setting this up.

@goldbattle goldbattle merged commit 28e31ae into ethz-asl:master Jan 16, 2024
3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants