Fixed delayed network detection attempting to overwrite read-only val…

…ue (#854).
ethers-io · May 29, 2020 · 8efd8d2 · 8efd8d2
1 parent 180a1af
commit 8efd8d2
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/providers/src.ts/base-provider.ts b/packages/providers/src.ts/base-provider.ts
@@ -271,12 +271,15 @@ export class BaseProvider extends Provider {
             }
 
             // This should never happen; every Provider sub-class should have
-            // suggested a network by here (or thrown).
+            // suggested a network by here (or have thrown).
             if (!network) {
                 logger.throwError("no network detected", Logger.errors.UNKNOWN_ERROR, { });
             }
 
-            defineReadOnly(this, "_network", network);
+            // Possible this call stacked so do not call defineReadOnly again
+            if (this._network == null) {
+                defineReadOnly(this, "_network", network);
+            }
         }
 
         return this._network;