-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: add support for new Sepolia chain #1581
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review is not yet complete (to be continued by me or someone else).
Is this Sepolia network already running? If so: have you (@emersonmacro) tested this setup in the client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some change requests, I will directly push these after the review.
The initial connection to the bootnode is now working with this.
We get the following follow-up error though:
Guess that has something to do with the genesis block which might not be written properly to the chain. This will need some debugging. A good starting point here is likely the blockchain library and there the related genesis block initialization code parts.
What's the status of this? |
I was able to get the same initial connection to the bootnode and subsequent error that you posted. I'm doing some debugging trying to figure out what's causing the error. |
i successfully sync'd to head but not sure why it didn't continue following the tip of the chain This error:
is concerning, might be related to |
Maybe no one is mining Sepolia so there are no new blocks? Check the timestamp of the latest block? |
But this Sepolia network is a great chance to really really test our client in production, and all the related tip of the chain behavior with it! 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM!
we can address following the tip of chain behavior in a separate PR, and this should be a nice testnet to do that with :)
Initial attempt at tackling #1558. Information for the new chain came primarily from the geth issue & PR here:
ethereum/go-ethereum#23730 (comment)
https://github.com/ethereum/go-ethereum/pull/23730/files#diff-c13a1b5c84048a832e07e3503cc35f66614816cb39fe1e2fdd992672a9e1d883R46