Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Remove custody placeholder from phase 0 #1262

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Remove custody placeholder from phase 0 #1262

merged 3 commits into from
Nov 12, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Nov 10, 2019

What was wrong?

Part of #1261: Removing custody placeholder from phase 0
spec issue: ethereum/consensus-specs#1462

How was it fixed?

  • Remove custody_bits from Attestation.
  • Remove custody_bit_1_indices from IndexedAttestation.
  • Rename IndexedAttestation.custody_bit_0_indices to IndexedAttestation.attesting_indices.
  • Update corresponding logic.
  • Bump test vector to v0.9.1.

To-Do

  • Clean up commit history

Cute Animal Picture

king-penguin-1801565_640

@hwwhww hwwhww added the eth2.0 label Nov 10, 2019
ralexstokes
ralexstokes approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

anything else you want to do before we merge this in?

@hwwhww hwwhww merged commit f94c1aa into ethereum:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
eth2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @ralexstokes