Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custody_bits and AttestationDataAndCustodyBit #1462

Closed
wants to merge 4 commits into from

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Nov 2, 2019

NOTE: This was Merged. There is some sort of github bug that is showing this as Closed, but disregard that.

These two constructions weren't originally removed from v0.9.0 to attempt to not disrupt the status quo where unnecessary. As we dig deeper into the Phase 1 spec, the custody bit construction is altered from this original construction to be on a per block basis and the placeholder in phase 0 would eventually have to be removed come phase 1 anyway.

I suggest we remove this and release as a v0.9.1 along with some other minor changes in the queue

changelog:

  • remove custody_bits from Attestation
  • replace bit_0_indices and bit_1_indices in IndexedAttestation with a singular attesting_indices
  • remove AttestationDataAndCustodyBit and replace the attestation signing as just over attestation.data
  • use a bls_verify instead of a bls_verify_multiple in process_attestation
  • minor adjustments to validator and fork choice wrt these changes
  • update tests accordingly

Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a plan for testing of phase 1, as the old custody code is assumed to be there still. It looks good otherwise, no more unstable stubs in phase 0 is probably for the best. 👍

specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
Remove custody_bits and AttestationDataAndCustodyBit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants