Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(census): split census into multiple files and remove "Subnetwork" #1503

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

morph-dev
Copy link
Collaborator

What was wrong?

Currently all census logic is in one file. This makes any future changes harder to review (as more files will be created and history might not be preserved).

How was it fixed?

This PR has 3 small commits:

  • move Network and Subnetwork into separate file
  • remove Subnetwork type and use similar one from ethportal-api crate
  • select peers randomly
    • I believe that current implementation always selects the same peers (at least until peers collection is updated, which isn't frequent)

To-Do

@morph-dev morph-dev added the portal-bridge Portal bridge label Oct 1, 2024
@morph-dev morph-dev self-assigned this Oct 1, 2024
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@morph-dev morph-dev merged commit 9787399 into ethereum:master Oct 2, 2024
9 checks passed
@morph-dev morph-dev deleted the state_bridge_census branch October 2, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portal-bridge Portal bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants