Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-3860: Update tests for CREATE/CREATE2 according to spec change #1105

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Nov 24, 2022

The spec was clarified and geth implementation changed:

  1. Nonce is not incremented when CREATE/CREATE2 fails due to initcode size above limit
  2. Initcode charge is not deducted when CREATE/CREATE2 fails due to initcode size above limit

ethereum/EIPs#6040
ethereum/go-ethereum#23847

@gumb0 gumb0 marked this pull request as ready for review November 25, 2022 11:11
@winsvega winsvega merged commit 9e058e5 into ethereum:develop Nov 29, 2022
@gumb0 gumb0 deleted the eip-3860-nonce branch November 29, 2022 16:59
yperbasis added a commit to erigontech/erigon that referenced this pull request Nov 30, 2022
yperbasis added a commit to erigontech/erigon that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants