This repository has been archived by the owner on Aug 8, 2018. It is now read-only.
Fix eth gas limit missing #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5009882.
… be executed for testing the rpc client
…charia/pyethapp into fix_eth_gasLimit_missing
…able can be executed for testing the rpc client" This reverts commit 9124a41.
…can be executed for testing the rpc client
|
Addresses #150 |
| @@ -11,6 +11,7 @@ install: | |||
| - pip install -r requirements.txt | |||
| - pip install coveralls readme_renderer | |||
| script: | |||
| - python setup.py install | |||
There was a problem hiding this comment.
is this necessary for this issue?
There was a problem hiding this comment.
This was added to invoke the Popen(['pyethapp']). Otherwise it won't find the executable.
There was a problem hiding this comment.
Well the transport can be mocked int the same way as in #168 so this will not be necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@4gn3s I pulled your changes and fixed the tests