Skip to content
This repository has been archived by the owner on Aug 8, 2018. It is now read-only.

No tests for the JSONRPCClient #150

Open
RomanZacharia opened this issue Jul 7, 2016 · 2 comments
Open

No tests for the JSONRPCClient #150

RomanZacharia opened this issue Jul 7, 2016 · 2 comments

Comments

@RomanZacharia
Copy link

Most of the code in https://github.com/ethereum/pyethapp/blob/develop/pyethapp/rpc_client.py is not covered by tests.

@rjl493456442
Copy link
Member

Do you means some rpc method has not been implemented but it been called in the code?
Like gaslimit called eth_gasLimit or lastgasprice called eth_lastGasPrice?
I find the same problem as yours.

@mattvonrocketstein
Copy link

Just to do something productive, I'm actually looking to contribute utests while I learn more parts of the code. I'm happy to look into fixing this issue if anyone can speak up and comment as to whether the API is basically stable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants