Remove unnecessary node read #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids "touching" trie nodes that don't need to be read. This is important in cases like building witnesses based on nodes that are read out from the database.
carver
force-pushed
the
remove-unnecessary-node-read
branch
from
156690d
to
478f13f
Compare
pipermerriam
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
squash_changeswas always reading the root node, even if the trie was never modified. The correct behavior here is to not read out the root node from the database.This might be relevant when building witnesses.
How was it fixed?
Check if the root hash changed, before reading out the old root node from the database.
Cute Animal Picture