Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethstats: fix bug in block reporting #28398

Merged
merged 2 commits into from Oct 23, 2023
Merged

ethstats: fix bug in block reporting #28398

merged 2 commits into from Oct 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2023

Fixed Geth always reporting 0 txs per block while other node implementations report it correctly on https://ethstats.dev/.

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like this was broken by cd31f2d
where CurrentBlock was changed to return a header, which fails the type assertion on line 634

ethstats/ethstats.go Outdated Show resolved Hide resolved
ethstats/ethstats.go Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Oct 23, 2023

@holiman Done

@ghost ghost requested a review from holiman October 23, 2023 12:52
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman changed the title ethstats: Fixed full node report ethstats: fix bug in block reporting Oct 23, 2023
@holiman holiman added this to the 1.13.5 milestone Oct 23, 2023
@holiman holiman merged commit 54f35c6 into ethereum:master Oct 23, 2023
2 checks passed
@holiman
Copy link
Contributor

holiman commented Oct 23, 2023

Thanks!

@ghost ghost deleted the ethstats-fix branch October 26, 2023 08:53
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Fixes a bug where the ethstats omits to report full block contents. This bug was a side-effect of ethereum#26777,  where `CurrentBlock` was changed to return a header instead of a block, leading to a failed type assertion.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
Fixes a bug where the ethstats omits to report full block contents. This bug was a side-effect of ethereum#26777,  where `CurrentBlock` was changed to return a header instead of a block, leading to a failed type assertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants