Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/tracers: add native flatCallTracer (aka parity style tracer) #26377

Merged
merged 54 commits into from
Feb 28, 2023
Merged

eth/tracers: add native flatCallTracer (aka parity style tracer) #26377

merged 54 commits into from
Feb 28, 2023

Commits on Nov 9, 2022

  1. eth/tracers/internal/tracetest,eth/tracers/internal/tracetest/testdat… 

    …a/call_tracer_flat

: add tests for flat call tracer
    @ziogaschr
    ziogaschr committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    92ecfa4 View commit details
    Browse the repository at this point in the history

  2. eth/tracers/native,go.mod,go.sum: add flatCall native tracer 

    :
    @ziogaschr
    ziogaschr committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    9369489 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. basic formatting

    @ziogaschr
    ziogaschr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    db274bc View commit details
    Browse the repository at this point in the history

  2. add some undeclared structs

    @ziogaschr
    ziogaschr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    95f7e3f View commit details
    Browse the repository at this point in the history

  3. read callFrameMarshaling.TypeString in flatTracer

    @ziogaschr
    ziogaschr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    457aba0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. change callFrame.Type to stringOpCode type for gencodec marshaling

    @ziogaschr
    ziogaschr committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    271a8b8 View commit details
    Browse the repository at this point in the history

  2. remove string quotes from stringOpCode.UnmarshalJSON

    @ziogaschr
    ziogaschr committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    3786e6a View commit details
    Browse the repository at this point in the history

  3. cleanup flatTracer code

    @ziogaschr
    ziogaschr committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    68d8d4f View commit details
    Browse the repository at this point in the history

  4. remove debug code

    @ziogaschr
    ziogaschr committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    33c5e8f View commit details
    Browse the repository at this point in the history

  5. remove dead code

    @ziogaschr
    ziogaschr committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    f8df70a View commit details
    Browse the repository at this point in the history

  6. go mod tidy

    @ziogaschr
    ziogaschr committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    b0ec084 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Merge branch 'master' into feat/flat-call-tracer

    @ziogaschr
    ziogaschr committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0237599 View commit details
    Browse the repository at this point in the history

  2. go mod tidy

    @ziogaschr
    ziogaschr committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    1115e4a View commit details
    Browse the repository at this point in the history

  3. fix flatCallTracer tests for using parity configuration (WiP)

    @ziogaschr
    ziogaschr committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    f41caea View commit details
    Browse the repository at this point in the history

  4. flatCall tracer uses parent value for DELEGATECALL when zero

    @ziogaschr
    ziogaschr committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    e7e3a5f View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. fix top call frame gas used

    @s1na
    s1na committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    5c56e2c View commit details
    Browse the repository at this point in the history

  2. fix value inherited in delegatecall

    @s1na
    s1na committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    c9dd179 View commit details
    Browse the repository at this point in the history

  3. Exclude precompiles from calls 

    Co-authored-by: Chris Ziogas <ziogaschr@gmail.com>
    @s1na @ziogaschr
    s1na and ziogaschr committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    0e3ccf2 View commit details
    Browse the repository at this point in the history

  4. fix merge conflict

    @s1na
    s1na committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    3ab85b1 View commit details
    Browse the repository at this point in the history

  5. copy addrs

    @s1na
    s1na committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b2eeb0d View commit details
    Browse the repository at this point in the history

  6. refactor types

    @s1na
    s1na committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    65ebeaa View commit details
    Browse the repository at this point in the history

  7. avoid json bounce in GetResult

    @s1na
    s1na committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b2f54e8 View commit details
    Browse the repository at this point in the history

  8. minor cleanups

    @s1na
    s1na committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4cba0b4 View commit details
    Browse the repository at this point in the history

  9. s/convertedParityErrors/convertParityErrors for flat tracer tests

    @ziogaschr
    ziogaschr committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    cd7109c View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. fix test

    @s1na
    s1na committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    1f32a3a View commit details
    Browse the repository at this point in the history

  2. add blockNumber to context

    @s1na
    s1na committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    063f3c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. refactor result processing

    @s1na
    s1na committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    a402ba8 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. eth/tracers/native: change struct fields to pointers to be ommited fr… 

    …om JSON Marshaller

eth/tracers/native: change struct fields to pointers to be ommited from JSON Marshaller
    @ziogaschr
    ziogaschr committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e904a32 View commit details
    Browse the repository at this point in the history

  2. eth/tracers/native: copy child call

    @ziogaschr
    ziogaschr committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    af65397 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. eth/tracers/native: Child calls in flatCallTracer must have a value, … 

    …even if it's zero
    @ziogaschr
    ziogaschr committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    d4da340 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Merge branch 'master' into feat/flat-call-tracer

    @ziogaschr
    ziogaschr committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1ec73ba View commit details
    Browse the repository at this point in the history

  2. eth/tracers/native: update flatCallTracer to reflect new interfaces a… 

    …fter merge
    @ziogaschr
    ziogaschr committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    c457436 View commit details
    Browse the repository at this point in the history

  3. fix lint issue

    @s1na
    s1na committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    251a960 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. eth/tracers/internal/tracetest: update eth/tracers/internal/tracetest… 

    …/flat_calltrace_test.go

Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com>
    @ziogaschr @s1na
    ziogaschr and s1na authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5d13a74 View commit details
    Browse the repository at this point in the history

  2. eth/tracers/internal/tracetest: comment out debugging helpers

    @ziogaschr
    ziogaschr committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    bb887f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. go.mod, go.sum: run go mod tidy

    @ziogaschr
    ziogaschr committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    aebff89 View commit details
    Browse the repository at this point in the history

  2. eth/tracers/native: remove handling of value of a delegated call 

    This has been moved in callTracer context with PR ethereum#26632
    @ziogaschr
    ziogaschr committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    03efcd3 View commit details
    Browse the repository at this point in the history

  3. eth/tracers/native: change call_tracer_flat tests config to follow th… 

    …e config schema of go-ethereum
    @ziogaschr
    ziogaschr committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0890135 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Merge branch 'master' into feat/flat-call-tracer

    @ziogaschr
    ziogaschr committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d23e55c View commit details
    Browse the repository at this point in the history

  2. eth/tracers/native: call_flat tracer will display calls to precompiles 

    For compatibility with Parity tracer we had removed the internal calls to precompiles for CALL/STATICCALL.

Geth decides to present them so as to present the full information in the tracers
    @ziogaschr
    ziogaschr committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    04c37e4 View commit details
    Browse the repository at this point in the history

  3. eth/tracers/native: remove convertParityErrors from flat tracer 

    `convertParityErrors` tracer config option  has been used in order to keep errors same as in parity for compatibility.

Though, being compatibility in this level is not needed and is being removed for sanity
    @ziogaschr
    ziogaschr committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    40df204 View commit details
    Browse the repository at this point in the history

  4. eth/tracers/native: remove unused code

    @ziogaschr
    ziogaschr committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4ac7982 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. eth/tracers/native: geth gas usage is more accurate, accounting for i… 

    …ntrinsic gas and refunds
    @ziogaschr
    ziogaschr committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    69e7925 View commit details
    Browse the repository at this point in the history

  2. eth/tracers/native: flatCallTracer option to return Parity like forma… 

    …tted error for compatibility
    @ziogaschr
    ziogaschr committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    fe3cb25 View commit details
    Browse the repository at this point in the history

  3. eth/tracers/native: call_flat tracer option to handle calls to precom… 

    …piles

For compatibility with Parity tracer we had removed the internal calls to precompiles for CALL/STATICCALL.

Geth decides to present them so as to present the full information in the tracers

For compatibility with Parity tracer we added the option `IncludePrecompiles` in order to include/exclude the internal calls to precompiles for CALL/STATICCALL.
    @ziogaschr
    ziogaschr committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    41c2b50 View commit details
    Browse the repository at this point in the history

  4. eth/tracers/internal/tracetest/testdata/call_tracer_flat: add test fo… 

    …r “convertParityErrors” flatCall tracer option
    @ziogaschr
    ziogaschr committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    384facf View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. minor styling

    @s1na
    s1na committed Feb 14, 2023
    1 Configuration menu
    Copy the full SHA
    584c4c0 View commit details
    Browse the repository at this point in the history

  2. eth/tracers/native: flatCall blockNumber and transactionPosition are … 

    …non hex for compatibility
    @ziogaschr
    ziogaschr committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2f8fda0 View commit details
    Browse the repository at this point in the history

  3. eth/tracers: fix panic by filling the BLockNumber for blocks and bett… 

    …er handling nils in flatCall tracer
    @ziogaschr
    ziogaschr committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    916e279 View commit details
    Browse the repository at this point in the history

  4. Revert gasUsed compatibility trick

    @s1na
    s1na committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4f9a9aa View commit details
    Browse the repository at this point in the history

  5. eth/tracers/internal/tracetest/testdata/call_tracer_flat: fix tests f… 

    …or wrong gasUsed
    @ziogaschr
    ziogaschr committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1e34a1d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Revert gencodec type field conversion

    @s1na
    s1na committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ce1b7cc View commit details
    Browse the repository at this point in the history

  2. add comment

    @s1na
    s1na committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    65a0222 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Keep result in case of revert

    @s1na
    s1na committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    8e4714d View commit details
    Browse the repository at this point in the history