EIP-4488 Prototype Implementation #23983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Dec 10, 2021
| @@ -156,6 +157,9 @@ const ( | |||
| // up to half the consumed gas could be refunded. Redefined as 1/5th in EIP-3529 | |||
| RefundQuotient uint64 = 2 | |||
| RefundQuotientEIP3529 uint64 = 5 | |||
|
|
|||
| TxDataBaseBlockCap uint64 = 1048576 // Base block cap for transaction calldata in bytes | |||
| TxDataCapStipend uint64 = 300 // Per-tx cap stpiend for transaction calldata in bytes | |||
There was a problem hiding this comment.
Suggested change
| TxDataCapStipend uint64 = 300 // Per-tx cap stpiend for transaction calldata in bytes | |
| TxDataCapStipend uint64 = 300 // Per-tx cap stipend for transaction calldata in bytes |
axic
reviewed
Dec 10, 2021
| @@ -127,3 +133,17 @@ func CalcGasLimit(parentGasLimit, desiredLimit uint64) uint64 { | |||
| } | |||
| return limit | |||
| } | |||
|
|
|||
| // VerifyCalldataCap calculates the total calldata size of the block's transactions and | |||
| // verifies that it is below the cap introduced by EIP-XXXX | |||
There was a problem hiding this comment.
Why is this code using EIP4448 instead of EIPXXXX for variable names and comments?
|
This is getting very stale, I'm guessing there's not that much value in keeping this around anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft PR for illustration purposes only