Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix platformdirs dependency #985

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

petertdavies
Copy link
Collaborator

What was wrong?

The platformdirs dependency is required by ethereum-spec-evm daemon, but is only depended on by the test extra.

How was it fixed?

Move platformdirs dependency to install-requires.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@SamWilsn
Copy link
Collaborator

platformdirs is not required to use the specs as a library, so I think it should remain optional. Perhaps we do something like this instead:

try:
import rust_pyspec_glue
except ImportError as e:
# Add a message, but keep it an ImportError.
raise e from Exception(
"Install with `pip install 'ethereum[optimized]'` to enable this "
"package"
)

@SamWilsn SamWilsn merged commit 1e9a6e5 into ethereum:master Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants