Implement EIP-2537 #956
Merged
Implement EIP-2537 #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
force-pushed
the
eips/prague/eip-2537
branch
from
c6e3c88
to
55f4f76
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/prague #956 +/- ##
===============================================
Coverage ? 74.96%
===============================================
Files ? 688
Lines ? 38174
Branches ? 0
===============================================
Hits ? 28619
Misses ? 9555
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gurukamath
force-pushed
the
eips/prague/eip-2537
branch
from
d7e8a42
to
1360ff5
Compare
petertdavies
requested changes
Jul 24, 2024
gurukamath
force-pushed
the
eips/prague/eip-2537
branch
from
0e021e6
to
083a670
Compare
gurukamath
force-pushed
the
eips/prague/eip-2537
branch
from
083a670
to
8b38025
Compare
The current spec implementaion of the point evatuation pre-compile inttoduced in cancun makes use of eth2spec (consensus-specs). This leads to potential dependency conflicts like when execution-specs wants to use a different version of py_ecc than the consensus-specs. This commit removes the need to depend on eth2spec and implements the necessary components of KZG
gurukamath
force-pushed
the
eips/prague/eip-2537
branch
from
8b38025
to
54384a9
Compare
|
Re-based on the latest |
SamWilsn
reviewed
Aug 19, 2024
| G1_POINT_AT_INFINITY = b"\xc0" + b"\x00" * 47 | ||
| BLS_MODULUS = 52435875175126190479447740508185965837690552500527637822603658699938581184513 # noqa: E501 | ||
| KZG_SETUP_G2_LENGTH = 65 | ||
| KZG_SETUP_G2_MONOMIAL_1 = "0xb5bfd7dd8cdeb128843bc287230af38926187075cbfbefa81009a2ce615ac53d2914e5870cb452d2afaaab24f3499f72185cbfee53492714734429b7b38608e23926c911cceceac9a36851477ba4c60b087041de621000edc98edada20c1def2" # noqa: E501 |
There was a problem hiding this comment.
Why is this a hex string, while BLS_MODULUS is an integer?
There was a problem hiding this comment.
BLS_MODULUS is an integer.
KZG_SETUP_G2_MONOMIAL_1 is an G2 elliptic curve point encoded in a standard binary format.
There was a problem hiding this comment.
I guess my point is that KZG_SETUP_G2_MONOMIAL_1 is conceptually not a string. It should probably be Bytes?
| Verify KZG proof that ``p(z) == y`` where ``p(z)`` | ||
| is the polynomial represented by ``polynomial_kzg``. | ||
| Receives inputs as bytes. | ||
| Public method. |
There was a problem hiding this comment.
Visibility is normally indicated by the presence or absence of a leading underscore, where no underscore is "public."
src/ethereum/prague/vm/precompiled_contracts/bls12_381/__init__.py
Outdated
Show resolved
Hide resolved
src/ethereum/prague/vm/precompiled_contracts/bls12_381/__init__.py
Outdated
Show resolved
Hide resolved
src/ethereum/prague/vm/precompiled_contracts/bls12_381/__init__.py
Outdated
Show resolved
Hide resolved
src/ethereum/prague/vm/precompiled_contracts/bls12_381/bls12_381_g1.py
Outdated
Show resolved
Hide resolved
Support the state-test flag for the t8n tool
SamWilsn
approved these changes
Aug 23, 2024
petertdavies
approved these changes
Aug 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #936 )
What was wrong?
EIP-2537 needs is not currently implemented
Related to Issue #936
How was it fixed?
Implemented the EIP
Cute Animal Picture