Implement EIP 7685 and 6110 #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
May 4, 2024
petertdavies
requested changes
May 13, 2024
| @@ -103,3 +116,79 @@ class Receipt: | |||
| cumulative_gas_used: Uint | |||
| bloom: Bloom | |||
| logs: Tuple[Log, ...] | |||
|
|
|||
|
|
|||
| def validate_requests(requests: Tuple[Bytes, ...]) -> None: | |||
There was a problem hiding this comment.
You should also verify that the request root doesn't contain spurious requests with an unknown type. Otherwise the block builder could stuff arbitrary data into the requests list which is obviously bad.
Probably EIP 7685 should be updated to explicitly say that requests may not be included unless authorised by another EIP.
gurukamath
force-pushed
the
eips/prague/eip-7685
branch
from
b9b13ef
to
7dfd46f
Compare
gurukamath
force-pushed
the
eips/prague/eip-7685
branch
from
10ba0cd
to
47eb332
Compare
petertdavies
approved these changes
May 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #937 )
What was wrong?
The EIPs 7685 and 6110 were not implemented.
Related to Issue #937
How was it fixed?
Implement the EIPs for Prague
Cute Animal Picture