Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP-5656 for Cancun #851

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

gurukamath
Copy link
Collaborator

What was wrong?

EIP-5656, which is slated for Cancun, is not currently implemented in the specs.

How was it fixed?

Implemented EIP-5656

whitelist.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: 2208 lines in your changes are missing coverage. Please review.

Comparison is base (673ccec) 69.91% compared to head (4eaed5f) 69.93%.
Report is 53 commits behind head on forks/cancun.

Files Patch % Lines
src/ethereum/cancun/fork.py 0.00% 225 Missing ⚠️
src/ethereum/cancun/vm/instructions/system.py 0.00% 208 Missing ⚠️
src/ethereum/cancun/vm/instructions/__init__.py 0.00% 160 Missing ⚠️
src/ethereum/cancun/vm/instructions/environment.py 0.00% 143 Missing ⚠️
src/ethereum/cancun/state.py 0.00% 126 Missing ⚠️
src/ethereum/cancun/vm/instructions/arithmetic.py 0.00% 109 Missing ⚠️
src/ethereum/cancun/vm/interpreter.py 0.00% 108 Missing ⚠️
src/ethereum/cancun/vm/gas.py 0.00% 97 Missing ⚠️
src/ethereum/cancun/vm/instructions/stack.py 0.00% 94 Missing ⚠️
src/ethereum/cancun/vm/__init__.py 0.00% 76 Missing ⚠️
... and 55 more
Additional details and impacted files
@@               Coverage Diff                @@
##           forks/cancun     #851      +/-   ##
================================================
+ Coverage         69.91%   69.93%   +0.01%     
================================================
  Files               609      610       +1     
  Lines             33980    34309     +329     
================================================
+ Hits              23758    23993     +235     
- Misses            10222    10316      +94     
Flag Coverage Δ
unittests 69.93% <26.12%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petertdavies petertdavies merged commit 0c292f9 into ethereum:forks/cancun Jan 9, 2024
4 checks passed
@gurukamath gurukamath deleted the EIP-5656 branch January 24, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants