Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t8n: write output body to sys.stdout if specified #823

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Aug 24, 2023

What was wrong?

Specifying --output.body=stdout doesn't write the body to sys.stdout, but rather to a file called "stdout" in the directory specified by --output.basedir, or the current working directory, if unspecified.

Both the Geth and Nimbus t8n tools support specifying "stdout" to --output.body in order to write the txs rlp to the system's stdout. The geth, nimbus and ethereum-spec-evm share a common interface implementation in ethereum/execution-spec-tests; this is a discrepancy in their behavior.

Related to Issue ethereum/execution-spec-tests#268.

How was it fixed?

Write the txs rlp to sys.stdout if --output.body=stdout is specified, otherwise to the specified file. As previously, there is no output for the txs rlp if --output.body is omitted.

Cute Animal Picture

image

Copy link
Collaborator

@petertdavies petertdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, one minor quibble.

src/ethereum_spec_tools/evm_tools/t8n/__init__.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants