fix t8n tool errors #797
Merged
fix t8n tool errors #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
force-pushed
the
t8n-tool-errors
branch
from
7b2c462
to
a6c94f3
Compare
This commit handles a couple of edge cases 1. There are some error messages in the test fixtures that could raise RLPDecodingError or InvalidBlock depending on the context. For example TR_TypeNotSupported. If we try to include a typed transaction in Istanbul, it causes an RLPDecodingError. However, if we include a type 2 transaction in Berlin, it won't raise a RLPDecodingError since type1 and type2 are indistinguishable while decoding the rlp. In this case, it raises an InvalidBlock Exception. Therefore we stop making a distinction between these cases in the context of testing. 2. The test HighGasPrice raises a ValueError. We just raise a InvalidBlock from it.
SamWilsn
reviewed
Jun 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
=======================================
Coverage 74.06% 74.06%
=======================================
Files 571 571
Lines 31721 31726 +5
=======================================
+ Hits 23494 23498 +4
- Misses 8227 8228 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
SamWilsn
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Some edge cases were not handled properly by t8n
Related to Issue #773
How was it fixed?
ConstantinopleFixinstead ofConstantinopleGeneralStateTestsfixturest8ntool.Cute Animal Picture