Improve logging for malformed RPC responses

ethereum · Aug 13, 2024 · c5a2735 · c5a2735
1 parent 217ea17
commit c5a2735
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/src/ethereum_spec_tools/sync.py b/src/ethereum_spec_tools/sync.py
@@ -231,10 +231,22 @@ def fetch_blocks_debug(
 
         with request.urlopen(post) as response:
             replies = json.load(response)
+            if not isinstance(replies, list):
+                self.log.error(
+                    "got non-list JSON-RPC response. replies=%r", replies
+                )
+                raise ValueError
+
             block_rlps: Dict[int, Union[RpcError, bytes]] = {}
 
             for reply in replies:
-                reply_id = int(reply["id"], 0)
+                try:
+                    reply_id = int(reply["id"], 0)
+                except Exception:
+                    self.log.exception(
+                        "unable to parse RPC id. reply=%r", reply
+                    )
+                    raise
 
                 if reply_id < first or reply_id >= first + count:
                     raise Exception("mismatched request id")