feat(fw): Changes required for Devnet-4 Tests #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
type:chore
marioevz
force-pushed
the
pre-reqs-for-devnet-4-updates
branch
4 times, most recently
from
8b76a55
to
6ef9589
Compare
danceratopz
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Loving the precompile and system contract enums and the simplification this brings to forks.
I would suggest renaming this package from ethereum_test_addresses to ethereum_addresses as it's not really test specific.
Few comments below mainly regarding naming. At the cost of duplication, I would write the current version of system contract addresses in test Spec classes for ease of verification in the docs (see screenshot in comment below).
tests/prague/eip2935_historical_block_hashes_from_state/spec.py
Outdated
Show resolved
Hide resolved
marioevz
force-pushed
the
pre-reqs-for-devnet-4-updates
branch
from
c60dbfa
to
2c5594b
Compare
|
Scrapped |
fixup: BlockchainEngine changelog fixup(docs): BlockchainTestEngine docs Co-authored-by: danceratopz <danceratopz@gmail.com>
marioevz
force-pushed
the
pre-reqs-for-devnet-4-updates
branch
from
2c5594b
to
818c87f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR can be best reviewed (and also merged via any method that is not Squash) by commit.
Allow Bytes(), add sha256 method
Allow instantiating an empty
Bytesinstance by calling it with no parameters, and also add asha256method to allBytesinstances, which returns aHashinstance containing the sha256 digest.Allow instantiating Address with a label
Adds keyword argument
labeltoAddressinit method to allow it being instantiated with a label.Fix FixedSizeBytes comparison
Minor fix to
FixedSizeBytes__eq__method to fix casting of theotherelement under comparison, and allow comparing againstNonewithout raising an exception.Add BlockchainTestEngine
Adds a
BlockchainTestEnginespec which has all the same properties asBlockchainTestexcept that it only generates a blockchain test engine version fixture.Allow
nonceinfund_eoaAllows specifying a starting nonce for the funded EOA, which could only be achieved during fill but not on execution.
Allow Bytes in Initcode
Minor fix to allow deploying arbitrary bytes in an Initcode.
🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.