Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fw): Refactor ethereum_test_tools into separate libraries #645

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 22, 2024

🗒️ Description

Creates the following libraries out of ethereum_test_tools:

  • ethereum_test_base_types
  • ethereum_test_exceptions
  • ethereum_test_fixtures
  • ethereum_test_specs
  • ethereum_test_types
  • ethereum_test_vm

This will allow better interaction between them and reuse of code (e.g. Opcodes in ethereum_test_forks).

ethereum_test_fixtures still contains references to execution-specs, but it's possible to remove them so they can import this library alone and use it to consume the fixtures.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:refactor Type: Refactor scope:fw Scope: Framework (evm|tools|forks|pytest) labels Jun 22, 2024
@marioevz marioevz force-pushed the refactor-tools-into-separate-libraries branch 3 times, most recently from fb4f29d to f3ce7af Compare July 3, 2024 16:36
@marioevz marioevz force-pushed the refactor-tools-into-separate-libraries branch 3 times, most recently from a18e9fb to 8315cc5 Compare July 11, 2024 19:24
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@marioevz marioevz force-pushed the refactor-tools-into-separate-libraries branch from 8315cc5 to a74b028 Compare July 16, 2024 23:08
@marioevz marioevz merged commit be706d0 into main Jul 16, 2024
7 checks passed
@marioevz marioevz deleted the refactor-tools-into-separate-libraries branch July 16, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants