Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PayloadV3 with data gas used #417

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Update PayloadV3 with data gas used #417

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f5224e
Update PayloadV3 with data gas used
terencechain May 31, 2023
4b7eb72
Update src/engine/experimental/blob-extension.md
terencechain May 31, 2023
45878f6
DGU then EDG
terencechain Jun 1, 2023
75ba300
Fix order
terencechain Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/engine/experimental/blob-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ This extension is backwards-compatible, but not part of the initial Engine API.

### ExecutionPayloadV3

This structure has the syntax of `ExecutionPayloadV2` and appends a single field: `excessDataGas`.
This structure has the syntax of `ExecutionPayloadV2` and append two new fields: `excessDataGas` and `dataGasUsed`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe switch order here as well for consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

75ba300


- `parentHash`: `DATA`, 32 Bytes
- `feeRecipient`: `DATA`, 20 Bytes
Expand All @@ -44,7 +44,8 @@ This structure has the syntax of `ExecutionPayloadV2` and appends a single field
- `blockHash`: `DATA`, 32 Bytes
- `transactions`: `Array of DATA` - Array of transaction objects, each object is a byte list (`DATA`) representing `TransactionType || TransactionPayload` or `LegacyTransaction` as defined in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718)
- `withdrawals`: `Array of WithdrawalV1` - Array of withdrawals, each object is an `OBJECT` containing the fields of a `WithdrawalV1` structure.
- `excessDataGas`: `QUANTITY`, 256 bits
- `excessDataGas`: `QUANTITY`, 64 Bits
- `dataGasUsed`: `QUANTITY`, 256 bits
terencechain marked this conversation as resolved.
Show resolved Hide resolved
mkalinin marked this conversation as resolved.
Show resolved Hide resolved

### BlobsBundleV1

Expand Down