Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC: Add finalized and safe blocks #200

Merged
merged 15 commits into from
May 10, 2022
Merged

JSON-RPC: Add finalized and safe blocks #200

Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9b7b4f0
JSON-RPC: Add finalized block
mkalinin Mar 16, 2022
f024035
Add "safe" and "unsafe" block tags
mkalinin Mar 22, 2022
03fa4ef
Add description to the new block tags
mkalinin Mar 22, 2022
85a0740
Add detailed description to block tags
mkalinin Mar 23, 2022
be4858e
Replace newlines with `;` in OpenRPC description
mkalinin Mar 24, 2022
2c8dfe4
Update description of block tags
mkalinin Mar 25, 2022
76500f4
Add crypto to spellcheck exceptions
mkalinin Mar 25, 2022
ac7be22
Return latest to the block tag enum
mkalinin Mar 30, 2022
652ffb0
JSON-RPC: return error if finalized or safe block doesn't exist yet
mkalinin Apr 29, 2022
d1b1a98
JSON-RPC: specify error in case of non-existing finalized block
mkalinin May 2, 2022
54a1857
JSON-RPC: fix error code for non-existing finalized block
mkalinin May 2, 2022
2554fc3
Revert "JSON-RPC: fix error code for non-existing finalized block"
mkalinin May 2, 2022
f145a27
JSON-RPC: adjust Unknown block error code with JSON-RPC spec
mkalinin May 3, 2022
1d19753
Replace with
mkalinin May 6, 2022
b8d3967
Update block tags description
mkalinin May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/schemas/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@
"BlockTag": {
"title": "Block tag",
"type": "string",
"enum": ["earliest", "latest", "pending"]
"enum": ["earliest", "latest", "pending", "finalized", "safe", "unsafe"],
"description": "Tags \"finalized\" and \"safe\" refer to the corresponding blocks defined by the most recent fork choice state. Tag \"unsafe\" is an alias to the \"latest\"."
mkalinin marked this conversation as resolved.
Show resolved Hide resolved
mkalinin marked this conversation as resolved.
Show resolved Hide resolved
},
"BlockNumberOrTag": {
"title": "Block number or tag",
Expand Down