This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* update online (#769) * Update index.pug * modify vitalik's website (#766) * Update crowdsale.md (#765) The token is actually defined as an interface not a contract * Update footer 2017 -> 2018 (#764) * A tiny typo fix (#762) * Update recipes.pug (#757) * Update index.pug (#756) * Update Ether FAQ (#752) * Docs improvement to match interface (#751) Case & space now better match interface. Comment naming step unnecessarily confuses due to interface mismatch. Also, some grammar cleanup. * Updating deprecated .send(...) to .transfer(...) (#734) .send(...) is now deprecated. Send vs transfer comparsion: https://vomtom.at/solidity-send-vs-transfer/ Also the Solidity by Example Documentation got updated and now uses the .transfer() function. http://solidity.readthedocs.io/en/develop/solidity-by-example.html We dont need to use require, as transfer fully propagates errors. * Update contract Token name (#732) It should be "contract Token", not "contract token". Also transferFrom is missing in the contract, added it to contract Token. * English grammatical mistakes (#767) * Corrected English grammatical mistake * Corrected English grammatical mistake * Gh pages 2017 01 04 (#768) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * update dependencies * new build * update 2018 * update foundation page * Gh pages ud3 (#790) * es6 changes and node andnpm version update * Update index.pug * Update token.md * modify vitalik's website (#766) * Update crowdsale.md (#765) The token is actually defined as an interface not a contract * Update footer 2017 -> 2018 (#764) * A tiny typo fix (#762) * Update recipes.pug (#757) * Update index.pug (#756) * Update Ether FAQ (#752) * Docs improvement to match interface (#751) Case & space now better match interface. Comment naming step unnecessarily confuses due to interface mismatch. Also, some grammar cleanup. * Updating deprecated .send(...) to .transfer(...) (#734) .send(...) is now deprecated. Send vs transfer comparsion: https://vomtom.at/solidity-send-vs-transfer/ Also the Solidity by Example Documentation got updated and now uses the .transfer() function. http://solidity.readthedocs.io/en/develop/solidity-by-example.html We dont need to use require, as transfer fully propagates errors. * Update contract Token name (#732) It should be "contract Token", not "contract token". Also transferFrom is missing in the contract, added it to contract Token. * English grammatical mistakes (#767) * Corrected English grammatical mistake * Corrected English grammatical mistake * Gh pages 2017 01 04 (#768) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * update dependencies * new build * update 2018 dates * update 2018 * Develop (#727) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * Update Timeline.md ethereum -> Ethereum * Fix Constructor word typo Fix Constructor word typo * Fixed phrase for better clarity. (#776) "The console has auto completion and history support" was changed to: "The console has auto completion of commands and command-history support" * Rephrased for better clarity. Changed: generate an account to: create an account * Used 'CAUTION' to highlight POTENTIAL MONEY LOSS. 'CAUTION' is a more suitable word than 'ATTENTION', in order to highlight POTENTIAL MONEY LOSS. For reference, on Technical Writing, visit: http://www.stevensstrategic.com/technical-writing-the-difference-between-warnings-and-cautions/ * remove duplicated line this line had been duplicated "If you have not installed a compiler, then you need to install one. You can find [instructions for installing Solidity here](http://solidity.readthedocs.io/en/develop/installing-solidity.html)." * Add necessary 'public' to function in tutorial Without adding 'public' to that line of code, Ethereum Wallet returns the error: No visibility specified. Defaulting to "public". function Token(uint256 initialSupply) { ^ Spanning multiple lines. Proposing to add that in so tutorial takers don't run into this error, get confused, etc. * missing '>' * [admin.nodeInfo.nodeURL] >> [admin.nodeInfo.enode] The command 'admin.nodeInfo.nodeURL', results in 'undefined', in the recent version of Geth. Here is the actual output, based on the recent version of Geth: myMac:console2 admin$ geth attach ipc:../node2/geth.ipc Welcome to the Geth JavaScript console! instance: Geth/v1.7.3-stable/darwin-amd64/go1.9.2 coinbase: 0x3fd97155061e47960b59b563a178fa248493017c at block: 2 (Thu, 11 Jan 2018 20:25:58 +04) datadir: /Users/admin/EtherNet/testnet/node2 modules: admin:1.0 clique:1.0 debug:1.0 eth:1.0 miner:1.0 net:1.0 personal:1.0 rpc:1.0 txpool:1.0 web3:1.0 > web3.eth.accounts ["0x3fd97155061e47960b59b563a178fa248493017c"] > admin.nodeInfo.nodeURL undefined > admin.nodeInfo.enode "enode://f48fcf69ba27442ff3813912ec12ea1ad249f14739dabfcadb3985c3654540e047700030adba5800bf33d0adbdd9ca5f1c47aae2498a0d9dafb8c2fd730969b4@[::]:3002?discport=0" > * Follow correct style guide for code * Update Greeter tutorial to comply with change in Remix's UI (#779) * Clarifications on installing Solc vs using Remix * update docs to reflect Remix GUI change * Clarifications on retrieving ABI from Remix * formatting cleanup * Fixed app.js and updated /dist * Add error handling to Greeter tutorial (#774) * Add error handling to Greeter tutorial While trying to get up and running with contract deployment through geth, I spent multiple hours trying to debug the `greeterFactory.new(...)` command in this tutorial without realizing that I was getting an "Error: exceeds block gas limit" error. This change makes it so that the console will log if contract deployment fails. * Use early return for error handling. * Removed the Ethereum Alarm Clock (#729) Removed the Ethereum Alarm Clock as it is not available on all networks * updating foundation page * updating foundation page again * update/fix on foundation page * Update Foundation Page (#789) * updating foundation page * updating foundation page again * update/fix on foundation page * updating greeter to the current on on gh-pages * update to foundation page * update to brand * Update website (#814) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * es6 changes and node andnpm version update * Update index.pug * Update token.md * modify vitalik's website (#766) * Update crowdsale.md (#765) The token is actually defined as an interface not a contract * Update footer 2017 -> 2018 (#764) * A tiny typo fix (#762) * Update recipes.pug (#757) * Update index.pug (#756) * Update Ether FAQ (#752) * Docs improvement to match interface (#751) Case & space now better match interface. Comment naming step unnecessarily confuses due to interface mismatch. Also, some grammar cleanup. * Updating deprecated .send(...) to .transfer(...) (#734) .send(...) is now deprecated. Send vs transfer comparsion: https://vomtom.at/solidity-send-vs-transfer/ Also the Solidity by Example Documentation got updated and now uses the .transfer() function. http://solidity.readthedocs.io/en/develop/solidity-by-example.html We dont need to use require, as transfer fully propagates errors. * Update contract Token name (#732) It should be "contract Token", not "contract token". Also transferFrom is missing in the contract, added it to contract Token. * English grammatical mistakes (#767) * Corrected English grammatical mistake * Corrected English grammatical mistake * Gh pages 2017 01 04 (#768) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * update dependencies * new build * update 2018 dates * update 2018 * Develop (#727) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * Update Timeline.md ethereum -> Ethereum * Fix Constructor word typo Fix Constructor word typo * Fixed phrase for better clarity. (#776) "The console has auto completion and history support" was changed to: "The console has auto completion of commands and command-history support" * Rephrased for better clarity. Changed: generate an account to: create an account * Used 'CAUTION' to highlight POTENTIAL MONEY LOSS. 'CAUTION' is a more suitable word than 'ATTENTION', in order to highlight POTENTIAL MONEY LOSS. For reference, on Technical Writing, visit: http://www.stevensstrategic.com/technical-writing-the-difference-between-warnings-and-cautions/ * remove duplicated line this line had been duplicated "If you have not installed a compiler, then you need to install one. You can find [instructions for installing Solidity here](http://solidity.readthedocs.io/en/develop/installing-solidity.html)." * Add necessary 'public' to function in tutorial Without adding 'public' to that line of code, Ethereum Wallet returns the error: No visibility specified. Defaulting to "public". function Token(uint256 initialSupply) { ^ Spanning multiple lines. Proposing to add that in so tutorial takers don't run into this error, get confused, etc. * missing '>' * [admin.nodeInfo.nodeURL] >> [admin.nodeInfo.enode] The command 'admin.nodeInfo.nodeURL', results in 'undefined', in the recent version of Geth. Here is the actual output, based on the recent version of Geth: myMac:console2 admin$ geth attach ipc:../node2/geth.ipc Welcome to the Geth JavaScript console! instance: Geth/v1.7.3-stable/darwin-amd64/go1.9.2 coinbase: 0x3fd97155061e47960b59b563a178fa248493017c at block: 2 (Thu, 11 Jan 2018 20:25:58 +04) datadir: /Users/admin/EtherNet/testnet/node2 modules: admin:1.0 clique:1.0 debug:1.0 eth:1.0 miner:1.0 net:1.0 personal:1.0 rpc:1.0 txpool:1.0 web3:1.0 > web3.eth.accounts ["0x3fd97155061e47960b59b563a178fa248493017c"] > admin.nodeInfo.nodeURL undefined > admin.nodeInfo.enode "enode://f48fcf69ba27442ff3813912ec12ea1ad249f14739dabfcadb3985c3654540e047700030adba5800bf33d0adbdd9ca5f1c47aae2498a0d9dafb8c2fd730969b4@[::]:3002?discport=0" > * Follow correct style guide for code * Update Greeter tutorial to comply with change in Remix's UI (#779) * Clarifications on installing Solc vs using Remix * update docs to reflect Remix GUI change * Clarifications on retrieving ABI from Remix * formatting cleanup * Fixed app.js and updated /dist * Add error handling to Greeter tutorial (#774) * Add error handling to Greeter tutorial While trying to get up and running with contract deployment through geth, I spent multiple hours trying to debug the `greeterFactory.new(...)` command in this tutorial without realizing that I was getting an "Error: exceeds block gas limit" error. This change makes it so that the console will log if contract deployment fails. * Use early return for error handling. * Removed the Ethereum Alarm Clock (#729) Removed the Ethereum Alarm Clock as it is not available on all networks * Update Foundation Page (#789) * updating foundation page * updating foundation page again * update/fix on foundation page * Delete e-mail and change press-kit wording * Update Remix URL (#797) * Transfer of zero ERC20 Token must success (#796) * Make check for overflows compliant with ERC20 As my previous change: the ERC20 standard says that a transfer of 0 token MUST success. So we need to replace > by >= when checking for overflows, or the transfer of 0 token will revert ;-) * Transfer of 0 token must success Same as previous change: to be ERC20 compliant, a token must allow transfert of 0 token. * Transfer of zero token MUST success If you look at the ERC20 token standard, here: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md#transfer You can read that: Transfers of 0 values MUST be treated as normal transfers and fire the Transfer event. But if you are too strict when checking for overflows, as now, the 0 token transaction will revert <:o) I think we need to change the > into >= to allow transfers of 0 token as required by the standard. * Update crowdsale.sol (#786) * Develop (#792) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * Update Emit Events (#808) * Update token-erc20.sol * Update token-erc20.sol * Add "public" to minimum viable token (#807) * Develop into master (#804) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * both -> two distinct (#810) because there are three clients but both implies that there are only two clients * Revert "Develop (#792)" (#812) This reverts commit 4f29530. * Add 'public' to remaining variables in MyToken (#801) * Update dao-association.sol (#798) Updated the contract in favor of the latest solidity build compilation. * Solidity fixes (#699) * Line has no effect The "numberOfVotes" variable is set to the new value two lines further down, so this line does nothing. * Proposals should be marked as executed whether they pass or not This prevents proposals that lost the vote from having a chance of submitting more yea votes after the close of voting, and still get executed. * Hudson 4-10-18 Updates (#826) * es6 changes and node andnpm version update * Update index.pug * Update token.md * modify vitalik's website (#766) * Update crowdsale.md (#765) The token is actually defined as an interface not a contract * Update footer 2017 -> 2018 (#764) * A tiny typo fix (#762) * Update recipes.pug (#757) * Update index.pug (#756) * Update Ether FAQ (#752) * Docs improvement to match interface (#751) Case & space now better match interface. Comment naming step unnecessarily confuses due to interface mismatch. Also, some grammar cleanup. * Updating deprecated .send(...) to .transfer(...) (#734) .send(...) is now deprecated. Send vs transfer comparsion: https://vomtom.at/solidity-send-vs-transfer/ Also the Solidity by Example Documentation got updated and now uses the .transfer() function. http://solidity.readthedocs.io/en/develop/solidity-by-example.html We dont need to use require, as transfer fully propagates errors. * Update contract Token name (#732) It should be "contract Token", not "contract token". Also transferFrom is missing in the contract, added it to contract Token. * English grammatical mistakes (#767) * Corrected English grammatical mistake * Corrected English grammatical mistake * Gh pages 2017 01 04 (#768) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * update dependencies * new build * update 2018 dates * update 2018 * Develop (#727) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * Update Timeline.md ethereum -> Ethereum * Fix Constructor word typo Fix Constructor word typo * Fixed phrase for better clarity. (#776) "The console has auto completion and history support" was changed to: "The console has auto completion of commands and command-history support" * Rephrased for better clarity. Changed: generate an account to: create an account * Used 'CAUTION' to highlight POTENTIAL MONEY LOSS. 'CAUTION' is a more suitable word than 'ATTENTION', in order to highlight POTENTIAL MONEY LOSS. For reference, on Technical Writing, visit: http://www.stevensstrategic.com/technical-writing-the-difference-between-warnings-and-cautions/ * remove duplicated line this line had been duplicated "If you have not installed a compiler, then you need to install one. You can find [instructions for installing Solidity here](http://solidity.readthedocs.io/en/develop/installing-solidity.html)." * Add necessary 'public' to function in tutorial Without adding 'public' to that line of code, Ethereum Wallet returns the error: No visibility specified. Defaulting to "public". function Token(uint256 initialSupply) { ^ Spanning multiple lines. Proposing to add that in so tutorial takers don't run into this error, get confused, etc. * missing '>' * [admin.nodeInfo.nodeURL] >> [admin.nodeInfo.enode] The command 'admin.nodeInfo.nodeURL', results in 'undefined', in the recent version of Geth. Here is the actual output, based on the recent version of Geth: myMac:console2 admin$ geth attach ipc:../node2/geth.ipc Welcome to the Geth JavaScript console! instance: Geth/v1.7.3-stable/darwin-amd64/go1.9.2 coinbase: 0x3fd97155061e47960b59b563a178fa248493017c at block: 2 (Thu, 11 Jan 2018 20:25:58 +04) datadir: /Users/admin/EtherNet/testnet/node2 modules: admin:1.0 clique:1.0 debug:1.0 eth:1.0 miner:1.0 net:1.0 personal:1.0 rpc:1.0 txpool:1.0 web3:1.0 > web3.eth.accounts ["0x3fd97155061e47960b59b563a178fa248493017c"] > admin.nodeInfo.nodeURL undefined > admin.nodeInfo.enode "enode://f48fcf69ba27442ff3813912ec12ea1ad249f14739dabfcadb3985c3654540e047700030adba5800bf33d0adbdd9ca5f1c47aae2498a0d9dafb8c2fd730969b4@[::]:3002?discport=0" > * Follow correct style guide for code * Update Greeter tutorial to comply with change in Remix's UI (#779) * Clarifications on installing Solc vs using Remix * update docs to reflect Remix GUI change * Clarifications on retrieving ABI from Remix * formatting cleanup * Fixed app.js and updated /dist * Add error handling to Greeter tutorial (#774) * Add error handling to Greeter tutorial While trying to get up and running with contract deployment through geth, I spent multiple hours trying to debug the `greeterFactory.new(...)` command in this tutorial without realizing that I was getting an "Error: exceeds block gas limit" error. This change makes it so that the console will log if contract deployment fails. * Use early return for error handling. * Removed the Ethereum Alarm Clock (#729) Removed the Ethereum Alarm Clock as it is not available on all networks * Update Foundation Page (#789) * updating foundation page * updating foundation page again * update/fix on foundation page * Delete e-mail and change press-kit wording * Update Remix URL (#797) * Transfer of zero ERC20 Token must success (#796) * Make check for overflows compliant with ERC20 As my previous change: the ERC20 standard says that a transfer of 0 token MUST success. So we need to replace > by >= when checking for overflows, or the transfer of 0 token will revert ;-) * Transfer of 0 token must success Same as previous change: to be ERC20 compliant, a token must allow transfert of 0 token. * Transfer of zero token MUST success If you look at the ERC20 token standard, here: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md#transfer You can read that: Transfers of 0 values MUST be treated as normal transfers and fire the Transfer event. But if you are too strict when checking for overflows, as now, the 0 token transaction will revert <:o) I think we need to change the > into >= to allow transfers of 0 token as required by the standard. * Update crowdsale.sol (#786) * Develop (#792) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * Update Emit Events (#808) * Update token-erc20.sol * Update token-erc20.sol * Add "public" to minimum viable token (#807) * Develop into master (#804) * fixes Greeter tutorial see #14738 * removes unneeded kine * tidy grammer slightly * Revert "Develop (#792)" (#812) This reverts commit 4f29530. * Add 'public' to remaining variables in MyToken (#801) * Update dao-association.sol (#798) Updated the contract in favor of the latest solidity build compilation. * Solidity fixes (#699) * Line has no effect The "numberOfVotes" variable is set to the new value two lines further down, so this line does nothing. * Proposals should be marked as executed whether they pass or not This prevents proposals that lost the vote from having a chance of submitting more yea votes after the close of voting, and still get executed. * Update Links (#815) * Created hackternship.md This will eventually be the address for hackternship.ethereum.org * Update and rename hackternship.md to grants.md * updated page * Updated votingDeadline variable to minExecutionDate (#818) * Updated votingDeadline variable to minExecutionDate * Update dao-congress.sol * Removed horizontal overflow generated by figures on mobile (#821) * Updated votingDeadline variable to minExecutionDate (#820) * Update Twitter links (#822) * Fixed ms dependency issue (#825)
- Loading branch information
1 parent
6c911ad
commit 7fac074