Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network warning spam #278

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented May 6, 2024

What was wrong?

When networks are changed but get out of sync between eth-typing and eth-utils, warnings are thrown.

How was it fixed?

Remove the warning, very few core networks change much. If folks need net networks, they can be added with the script.

Planning to add a CI process to run the script automatically.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

@reedsa reedsa marked this pull request as ready for review May 6, 2024 16:57
@reedsa reedsa requested review from pacrob, fselmo and kclowes May 6, 2024 16:57
Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating!

@reedsa reedsa merged commit 5555495 into ethereum:main May 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants