-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP4844: Clarify ratelimit behavior for sidecar with zero blobs #3174
Changes from 3 commits
5a75704
42121ad
518c49b
491bb1d
7204b5c
96a5536
8d841c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -226,6 +226,8 @@ The request MUST be encoded as an SSZ-container. | |||||
The response MUST consist of zero or more `response_chunk`. | ||||||
Each _successful_ `response_chunk` MUST contain a single `BlobsSidecar` payload. | ||||||
|
||||||
In cases where a slot contains a `BlobSidecar` that does not contain any blobs, but contain non-zero `beacon_block_root` and `beacon_block_slot`, `blobs_sidecar` **may be** skipped. | ||||||
|
||||||
Clients MUST keep a record of signed blobs sidecars seen on the epoch range | ||||||
`[max(current_epoch - MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS, EIP4844_FORK_EPOCH), current_epoch]` | ||||||
where `current_epoch` is defined by the current wall-clock time, | ||||||
|
@@ -247,6 +249,8 @@ disconnect and/or temporarily ban such an un-synced or semi-synced client. | |||||
Clients MUST respond with at least the first blobs sidecar that exists in the range, if they have it, | ||||||
and no more than `MAX_REQUEST_BLOBS_SIDECARS` sidecars. | ||||||
|
||||||
Clients MUST not respond with empty blobs sidecars. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To clarify what an "empty" blob sidecar is. It's a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
The following blobs sidecars, where they exist, MUST be sent in consecutive order. | ||||||
|
||||||
Clients MAY limit the number of blobs sidecars in the response. | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.