-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP4844: Update cryptography API and Fiat-Shamir logic #3038
Merged
Merged
Changes from 25 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
429e597
4844: Start moving cryptography functions to polynomial-commitments
asn-d6 22a4dcd
4844: hash_to_bls_field() doesn't use SSZ and does domain separation
asn-d6 b5959a1
4844: Refactor aggregation and move to polynomial-commitments
asn-d6 642f138
4844: Fix ToC
asn-d6 ff528a2
Merge branch 'dev' into pr3038
hwwhww 91476fe
Fix linter error
hwwhww 090dc7e
Blobs as flat ByteVector
dankrad 30d19a3
Move is_data_available from validator to beacon_chain
dankrad 0eb82cf
Set domain separators to empty string
dankrad 7631c18
Add placeholder domain separators for two protocols; add old transcri…
dankrad fe7af4b
Remove duplicate hash in
dankrad 46b6b24
Fix typo
dankrad 889deff
Fix doctoc
dankrad 83ca385
Fix typo
dankrad cbc170b
Fix tests
dankrad 89d4ae0
Fix doctoc
dankrad b9dfdaf
Happy linter
dankrad 033567b
Use Polynomial type consistently, vector_lincomb to poly_lincomb
dankrad e81d54c
Small fixes
dankrad 463948e
Fix get_sample_blob
dankrad a33a423
Make `blob_to_field_elements` return `Polynomial` and fix tests
hwwhww 31ad8a5
Rearrange presets
hwwhww 0174521
Proofread
hwwhww dfcf33c
By kev: Removes domain separators as constants, Removes second call t…
dankrad d98c103
Add name for Fiat-Shamir protocol
dankrad 80d4d09
Improve comments in polynomial-commitments.md
asn-d6 c8b8b53
Fix description of BLS_MODULUS
asn-d6 5354a96
blob_to_field_elements() -> blob_to_polynomial()
asn-d6 0e2e477
Use modular multiplication in compute_aggregated_poly_and_commitment
asn-d6 db619e2
Satisfy executable spec tests
asn-d6 cb46b11
Improve code that deals with the evaluation challenge
asn-d6 af48987
Minor spec improvements (after review by hww)
asn-d6 1c9a8db
Remove extra space
dankrad 186a2eb
Move `BYTES_PER_FIELD_ELEMENT` from presets to constants
hwwhww c130995
Clarify BYTES_PER_FIELD_ELEMENT comment a bit more
asn-d6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return type is wrong. how about:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in af48987
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, slightly annoying because
None
could also mean that the sidecar is not available (I know in python we would do this by raising an exception but not all languages would have that available).