Minor spec improvements (after review by hww)

ethereum · Nov 2, 2022 · af48987 · af48987
1 parent cb46b11
commit af48987
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/setup.py b/setup.py
@@ -616,7 +616,7 @@ def sundry_functions(cls) -> str:
 ROOTS_OF_UNITY = kzg.compute_roots_of_unity(TESTING_FIELD_ELEMENTS_PER_BLOB)
 
 
-def retrieve_blobs_sidecar(slot: Slot, beacon_block_root: Root) -> BlobsSidecar:
+def retrieve_blobs_sidecar(slot: Slot, beacon_block_root: Root) -> Optional[BlobsSidecar]:
     return "TEST"'''
 
     @classmethod

diff --git a/specs/eip4844/polynomial-commitments.md b/specs/eip4844/polynomial-commitments.md
@@ -152,12 +152,12 @@ def blob_to_polynomial(blob: Blob) -> Polynomial:
     """
     Convert a blob to list of BLS field scalars.
     """
-    r = Polynomial()
+    polynomial = Polynomial()
     for i in range(FIELD_ELEMENTS_PER_BLOB):
         value = int.from_bytes(blob[i * BYTES_PER_FIELD_ELEMENT: (i + 1) * BYTES_PER_FIELD_ELEMENT], ENDIANNESS)
         assert value < BLS_MODULUS
-        r[i] = value
-    return r
+        polynomial[i] = value
+    return polynomial
 ```
 
 #### `hash_to_bls_field`
@@ -178,9 +178,9 @@ def hash_to_bls_field(polys: Sequence[Polynomial],
     # Append each polynomial which is composed by field elements
     for poly in polys:
         for field_element in poly:
-            data += int.to_bytes(field_element, 32, ENDIANNESS)
+            data += int.to_bytes(field_element, BYTES_PER_FIELD_ELEMENT, ENDIANNESS)
 
-    # Append serialised G1 points
+    # Append serialized G1 points
     for commitment in comms:
         data += commitment