Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Comments udpates and variables renames #77

Merged
merged 6 commits into from
Apr 8, 2018
Merged

[chore] Comments udpates and variables renames #77

merged 6 commits into from
Apr 8, 2018

Conversation

ChihChengLiang
Copy link
Contributor

@ChihChengLiang ChihChengLiang commented Apr 7, 2018 •
edited
Loading

this is some minor fixes after reviewing recent issues, discussions, Casper economics, and contracts.

  • Removed comments more helpful.
  • reorder global variables
  • last_voter_rescale was originally designed for debugging purpose and thus unused. Now it is used for making changes in deposit_scale_factor more straightforward.
  • rename next_validator_index
  • rename get_total_*dyn_deposits
  • remove unused variable: start_epoch, as suggested in Remove unused local variable in proc_reward #74

djrtwo
djrtwo approved these changes Apr 7, 2018
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Happy to see next_validator_index standardized, better organization, and some of the superfluous comments be removed.

LGTM 👍

@ChihChengLiang ChihChengLiang merged commit 7ca538b into ethereum:master Apr 8, 2018
@ChihChengLiang ChihChengLiang deleted the some-minor-fixes branch April 8, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChihChengLiang @djrtwo